commit 10d66c25c406b713c36aa9e10001ebb25bc69f2f Author: William Casarin Date: Thu Jul 28 07:05:51 2022 -0700 commando-rune: show warning when creating runes with no restrictions Changelog-Added: Show warning when creating runes with no restrictions Signed-off-by: William Casarin doc/lightning-commando-rune.7.md | 5 ++++- doc/schemas/commando-rune.schema.json | 4 ++++ plugins/commando.c | 4 ++++ 3 files changed, 12 insertions(+), 1 deletion(-) commit 98185dfc2b6a9d264b111249fe890123b65ff492 Author: William Casarin Date: Fri Mar 25 12:46:54 2022 -0700 startup_regtest: add connect helper `connect 1 2` to connect from l1 to l2, etc contrib/startup_regtest.sh | 23 ++++++++++++++--------- 1 file changed, 14 insertions(+), 9 deletions(-) commit a3f5d31b09c91019be0fd257a65677bf22c10342 Author: William Casarin Date: Fri Mar 25 12:46:15 2022 -0700 startup_regtest: add experimental-offers contrib/startup_regtest.sh | 1 + 1 file changed, 1 insertion(+) commit cf2e2d7445a038d6c09eaa25a0540808de340816 Author: William Casarin Date: Mon Apr 4 12:50:25 2022 -0700 changelog: remove duplicate pr links CHANGELOG.md | 21 --------------------- 1 file changed, 21 deletions(-) commit 79c292908565629dc5922b11450246b14f17f4d7 Author: William Casarin Date: Mon Apr 4 12:49:47 2022 -0700 changelog: sort pr links CHANGELOG.md | 96 ++++++++++++++++++++++++++++++------------------------------ 1 file changed, 48 insertions(+), 48 deletions(-) commit f72a08c80261296f2649bb04c2f3b2552636d404 Author: William Casarin Date: Fri Mar 11 12:08:59 2022 -0800 websocketd: fix random failures by blocking stdin reads Example request that is dying: NEW REQUEST! lightning_websocketd:main [1955685] <-- bad request from safari read 507 write_all 1 -> websocket_to_lightningd -> read_payload_header read 2 read_all 1 read -11 <--- This tried to read a part of the header, is this -EAGAIN? read_all 0 should we be blocking on these reads? *dies* Fixes #5089 Changelog-Fixed: `experimental-websocket` intermittent read errors fixed Signed-off-by: William Casarin connectd/websocketd.c | 2 ++ 1 file changed, 2 insertions(+) commit 2b92ac423601413f740ca645ba21f394c0e202dc Author: William Casarin Date: Thu Feb 10 09:22:17 2022 -0800 bolt11: mark when expiry is decoded It looks like the x tag isn't marked when parsed either? common/bolt11.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) commit af16b9b9f411e13c5aff452ec9f7ecb334f8cf7c Author: William Casarin Date: Thu Feb 10 09:14:04 2022 -0800 bolt11: mark when we decode min_final_cltv_expiry It looks like decode_c doesn't set have_c unlike the other decode_ methods. At the start of the function, decode_c checks have_c to see if it's set, but it is never set. It seems like this could allow for duplicate c tags, which is probably not intended. Signed-off-by: William Casarin common/bolt11.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) commit ff84b3f77327c1ea6a733261256f17587d66d440 Author: William Casarin Date: Tue Jan 18 06:13:44 2022 -0800 json_add_invoice: fix crash if missing invstring If this field is missing for whatever reason (weird db state?) clightning will crash when listing invoices. Signed-off-by: William Casarin lightningd/invoice.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) commit cf2c4c5dde005f8f7499d45e0df98de859e548df Author: William Casarin Date: Fri Jan 7 13:58:40 2022 -0800 make: add ctags target For us vim users :) Signed-off-by: William Casarin Makefile | 3 +++ 1 file changed, 3 insertions(+) commit 105a88dde4d0261cb1025ab337a3a46913e0f7ff Author: William Casarin Date: Fri Sep 3 12:09:11 2021 -0700 docs/fetchinvoice: document payer_note Signed-off-by: William Casarin doc/lightning-fetchinvoice.7 | 9 +++++++-- doc/lightning-fetchinvoice.7.md | 4 +++- 2 files changed, 10 insertions(+), 3 deletions(-) commit d6ede8db1b29d1ff4ac0d1fcc1bc1b7f58ae055e Author: William Casarin Date: Fri May 1 02:19:11 2020 -0700 build: cleanup compiler output Hide CFLAGS and LDFLAGS line noise each time an object file is compiled or linked. Also add a `make show-flags` command for displaying CC, LD, CFLAGS and LDFLAG information. This is shown at the start of each build. Use `V=1 make` to restore original output make CC: gcc -DBINTOPKGLIBEXECDIR="../libexec/c-lightning" -Wall [..] LD: gcc -Og -Lexternal -lwallycore -lsecp256k1 -ljsmn [..] ... cc wallet/test/run-db.c cc lightningd/test/run-jsonrpc.c cc lightningd/test/run-invoice-select-inchan.c cc lightningd/test/run-log-pruning.c cc lightningd/test/run-find_my_abspath.c cc cli/test/run-large-input.c cc cli/test/run-remove-hint.c ld lightningd/lightning_hsmd ld lightningd/lightning_gossipd ld lightningd/lightning_openingd ld lightningd/lightning_channeld ld lightningd/lightning_closingd ... Signed-off-by: William Casarin Changelog-Changed: build: default compile output is prettier and much less verbose Makefile | 119 +++++++++++++++++++++++++++++++++++---------------------------- 1 file changed, 66 insertions(+), 53 deletions(-) commit 6f635b46fd868a9684136ac79b393d5cdfa7eb59 Author: William Casarin Date: Fri May 24 02:57:30 2019 -0700 gossipstore: fix uninitialized input fd Initialize infd to STDIN_FILENO if the input file argument is missing. Caught with gcc version: 7.4.0 devtools/create-gossipstore.c: In function ‘main’: devtools/create-gossipstore.c:130:9: error: ‘infd’ may be used uninitialized in this function [-Werror=maybe-uninitialized] while (read_all(infd, &be_inlen, sizeof(be_inlen))) { Suggested-by: @ZmnSCPxj Signed-off-by: William Casarin devtools/create-gossipstore.c | 2 ++ 1 file changed, 2 insertions(+) commit 3f035cb3cc9431b5ae603b165e220efe494227c5 Author: William Casarin Date: Fri May 24 03:03:32 2019 -0700 gossipd: fix uninitialized free on short_route in goto path Fix a path where tal_free is called on an uninitialized variable If the first `goto bad_total` executes, then that path has uninitialized `short_route` but bad_total passes through to `out` whose first call is tal_free(short_route). This was noticed by a maybe-uninitialized heuristic on gcc 7.4.0: gossipd/routing.c: In function ‘find_shorter_route’: gossipd/routing.c:1096:2: error: ‘short_route’ may be used uninitialized in this function [-Werror=maybe-uninitialized] tal_free(short_route); Reported-by: @ZmnSCPxj Signed-off-by: William Casarin gossipd/routing.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 6b49b17d6effe037241a7d18b796d401eacc5687 Author: William Casarin Date: Mon Apr 8 13:08:57 2019 -0700 build: handle possible fscanf errors on gcc (GCC) 7.4.0 devtools/create-gossipstore.c: In function ‘load_scid_file’: devtools/create-gossipstore.c:22:9: error: ignoring return value of ‘fscanf’ ... fscanf(scidfd, "%d\n", &n); ^~~~~~~~~~~~~~~~~~~~~~~~~~ devtools/create-gossipstore.c:24:9: error: ignoring return value of ‘fscanf’ ... fscanf(scidfd, "%s\n", title); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~ cc1: all warnings being treated as errors make: *** [: devtools/create-gossipstore.o] Error 1 Signed-off-by: William Casarin devtools/create-gossipstore.c | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) commit 3d98ebbd7fda376c1d2ae6f6daa6389652ca0e55 Author: William Casarin Date: Mon Apr 8 13:06:01 2019 -0700 build: fix maybe-uninitialized error on some gcc versions on gcc (GCC) 7.4.0 devtools/create-gossipstore.c: In function ‘main’: devtools/create-gossipstore.c:107:9: error: ‘infd’ may be used uninitialized .. while (read_all(infd, &be_inlen, sizeof(be_inlen))) { ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Signed-off-by: William Casarin devtools/create-gossipstore.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 8a4ff05a4040a33346a03e48a08abed8c3a74f4d Author: William Casarin Date: Mon Apr 8 12:57:56 2019 -0700 nit: remove end-of-line whitespace Signed-off-by: William Casarin devtools/create-gossipstore.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) commit 9aaf2fe8d417479e1aac5f186491f55a159ba584 Author: William Casarin Date: Sat Mar 2 10:40:44 2019 -0800 build: fix uninitialized variable error on gcc 7.4.0 *best is checked for null before the comparison against the uninitialized variable ever happens, so this isn't a real issue. Initialize it to zero so that we don't fail to compile on certain gcc versions. plugins/pay.c: In function ‘add_shadow_route’: plugins/pay.c:644:18: error: ‘sample’ may be used uninitialized in this function if (!best || v > sample) { ~~^~~~~~~~ Signed-off-by: William Casarin plugins/pay.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 41468fb607ad4ed117ae8bc95838a668e7f234b9 Author: William Casarin Date: Thu Jan 10 16:38:05 2019 -0800 cli: source help from local docs when not installed Teach `lightning-cli help` to look in the doc directory relative to lightning-cli if it can't find the manpage in any man paths. This makes `lightning-cli help` work even if clightning hasn't been installed yet. Signed-off-by: William Casarin cli/lightning-cli.c | 25 ++++++++++++++++++++----- 1 file changed, 20 insertions(+), 5 deletions(-) commit a01342a66adbf2a88b69fcf74b8e1f7b192986fc Author: William Casarin Date: Wed Jan 9 21:22:46 2019 -0800 make: fail build if git isn't present git is needed to generate version information Add a sanity check so that the build don't continue with an empty VERSION. This is useful for sandboxed build where we might have forgot to include git. Signed-off-by: William Casarin Makefile | 5 +++++ 1 file changed, 5 insertions(+) commit 0fa209c64d87012f7365c9bce421482f70fa3e7f Author: William Casarin Date: Sun Dec 30 11:21:42 2018 -0500 lightningd: fix compile error in peer_control Error on gcc 7.3.0: lightningd/peer_control.c: In function ‘json_close’: lightningd/peer_control.c:955:3: error: ‘channel’ may be used uninitialized in this function [-Werror=maybe-uninitialized] channel_set_state(channel, ^~~~~~~~~~~~~~~~~~~~~~~~~~ channel->state, CHANNELD_SHUTTING_DOWN); Signed-off-by: William Casarin lightningd/peer_control.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 4d9190aa472e863f1328980b3030f8fb03e2f753 Author: William Casarin Date: Sun Dec 30 11:18:33 2018 -0500 lightningd: fix compile error on unused variable Switch to write_all instead Error on gcc 7.3.0: lightningd/lightningd.c: In function ‘on_sigterm’: lightningd/lightningd.c:587:9: error: ignoring return value of ‘write’, declared with attribute warn_unused_result [-Werror=unused-result] write(STDERR_FILENO, msg, strlen(msg)); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Signed-off-by: William Casarin lightningd/lightningd.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) commit db9e250df861e77129e62025c74422d11e96c37f Author: William Casarin Date: Mon Dec 10 09:28:11 2018 -0800 python: fix check-python errors in plugins Fixes some lint errors with unused variables: contrib/plugins/fail/failtimeout.py:48:5: F841 local variable 'e' is assigned to but never used contrib/plugins/helloworld.py:86:5: F841 local variable 'e' is assigned to but never used Signed-off-by: William Casarin contrib/plugins/fail/failtimeout.py | 2 +- contrib/plugins/helloworld.py | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) commit ad1cf8b40c203444519d30284743a43b786744c0 Author: William Casarin Date: Fri Nov 2 14:26:06 2018 -0700 build: fix compilation error on gcc 7.3.0 Signed-off-by: William Casarin onchaind/onchaind.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit b3f72362013875a7174a0fdd8af2214b7825f0df Author: William Casarin Date: Wed Oct 10 00:59:33 2018 -0700 python: add cheroot to requirements.txt It looks like this is a new dependency. Sort the list while we're at it. Signed-off-by: William Casarin tests/requirements.txt | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) commit 8f405ca9a72d446da26916298dc5bad175ba2671 Author: William Casarin Date: Mon Oct 8 18:15:44 2018 -0700 cli: fix human help output for the new jsonrpc help response Now that we're returning all the help data, we need to update the human_help formatter to handle the extra data. Signed-off-by: William Casarin cli/lightning-cli.c | 15 ++++++++++----- 1 file changed, 10 insertions(+), 5 deletions(-) commit d23a0e8adc9e870f41790dfb1c8f36f33b201cc7 Author: William Casarin Date: Mon Oct 8 18:14:18 2018 -0700 cli: handle missing manpages gracefully Instead of exiting when we can't find a manpage, set the command and continue so that we can try the json rpc for help. Signed-off-by: William Casarin cli/lightning-cli.c | 29 +++++++++++++++++++++++------ 1 file changed, 23 insertions(+), 6 deletions(-) commit cc4357f0a63181695309ad4a1e29c2be2a0c9f4f Author: William Casarin Date: Mon Oct 8 18:09:54 2018 -0700 rpc: add json_add_help_command for help command objects Instead of two code paths that return different help objects, simplify things by always returning the full help object. This not only includes description and the command name, but the verbose description as well. Signed-off-by: William Casarin lightningd/jsonrpc.c | 64 ++++++++++++++++++++++++++++------------------------ 1 file changed, 34 insertions(+), 30 deletions(-) commit f2488fbe14bcb6d68ab1114e4e18cfc20763046d Author: William Casarin Date: Mon Oct 8 19:45:55 2018 -0700 make: fix broken error message in bolt-check It looks like a printf was missing for the bolt-check error message Signed-off-by: William Casarin Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 7c4b9c8a0d5fd4b8c756fc0d87ece572b3afd78f Author: William Casarin Date: Mon Oct 8 16:02:02 2018 -0700 build: fix compile error on gcc ~7.3.0 It seems to be having a bit of trouble understanding the control flow to realize it's not actually uninitialized. Add an error handler after the switch in case we miss a real uninitialized error in the future. Signed-off-by: William Casarin devtools/gossipwith.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) commit 046a9c1a450326e64a4587b88ca08c0d692e6032 Author: William Casarin Date: Thu Aug 2 06:44:25 2018 -0700 doc: document p2sh-segwit address gen for faucet coins Now that the default newaddr type is bech32, this step seems to be tripping people up. Reported-by: #c-lightning users Signed-off-by: William Casarin README.md | 6 ++++++ 1 file changed, 6 insertions(+) commit 6195839783c7b949600c979a1632fe534fb406e8 Author: William Casarin Date: Tue Jul 31 17:53:20 2018 -0700 lightningd: show selected network defaults in usage This gives the network options a chance to load from arguments before usage exits, so that the proper defaults are shown. This didn't work: lightningd --mainnet --help before it showed testnet defaults, now it shows mainnet defaults. Signed-off-by: William Casarin lightningd/options.c | 20 +++++++++++++------- 1 file changed, 13 insertions(+), 7 deletions(-) commit 88692047302a971623f4f5863cf2b51c953962cf Author: William Casarin Date: Mon Jul 23 15:31:40 2018 -0700 test: add pytest-xdist to the python test requirements Signed-off-by: William Casarin tests/requirements.txt | 1 + 1 file changed, 1 insertion(+) commit 6e4745b28a22e58cb63974c74fecb426d7390d1c Author: William Casarin Date: Mon Jul 23 15:19:09 2018 -0700 doc: update python test requirements in HACKING Signed-off-by: William Casarin doc/HACKING.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) commit f8fa4213f1721f3c5e1e0bd027fb7153d60986e5 Author: William Casarin Date: Mon Jul 23 15:06:04 2018 -0700 tools: use /usr/bin/env bash instead of /bin/bash These commands fail on systems that do not have bash under /bin Signed-off-by: William Casarin tools/check-includes.sh | 2 +- tools/check-manpage.sh | 2 +- tools/check-markdown.sh | 2 +- tools/check-setup_locale.sh | 2 +- tools/check-spelling.sh | 2 +- tools/docker-entrypoint.sh | 2 +- tools/mockup.sh | 2 +- tools/rel.sh | 2 +- tools/update-mocks.sh | 2 +- 9 files changed, 9 insertions(+), 9 deletions(-) commit a9cf73380a03c21a096586f252177045733b7e8e Author: William Casarin Date: Tue Jul 3 06:48:03 2018 -0700 cli: launch a manpage when help is passed an argument example lightning-cli help pay lightning-cli help cli Signed-off-by: William Casarin cli/lightning-cli.c | 16 +++++++++++++++- 1 file changed, 15 insertions(+), 1 deletion(-) commit 4a1b68502e3485a6d192b94cad3240c600e195a3 Author: William Casarin Date: Tue Jul 3 07:37:01 2018 -0700 wallet: fix up semi-cryptic wallet error message There is evidence that this message can be confusing[1]. Suggest a way to resolve the error in the message. [1] https://www.reddit.com/r/Bitcoin/comments/7ybcq9/programming_how_can_i_resolve_the_below_error/ Signed-off-by: William Casarin wallet/wallet.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) commit a88ab1634fc7521e88f991671391c7b2f7edb1f8 Author: William Casarin Date: Sun Jul 1 12:13:22 2018 -0700 cli: add manpage hint at the end of human help output It may not immediately obvious that this is available Signed-off-by: William Casarin cli/lightning-cli.c | 2 ++ 1 file changed, 2 insertions(+) commit d7aa0528b879447653f69a6eed372a6bd667aa6a Author: William Casarin Date: Wed Jun 20 07:06:08 2018 -0700 gossipd: fix compile error, uninitialized variable Seems to be a problem with gcc 6.4+? Fixes #1527 Signed-off-by: William Casarin gossipd/tor_autoservice.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 3d27bbb47d04c091ce85d745564eb5cb44166a26 Author: William Casarin Date: Wed Jan 24 10:37:23 2018 -0800 test: test_bech32_funding 1. Test wallet funding to a bech32 p2wpkh address 2. Test channel opening with this address Signed-off-by: William Casarin tests/test_lightningd.py | 26 ++++++++++++++++++++++++++ tests/utils.py | 17 +++++++++++------ 2 files changed, 37 insertions(+), 6 deletions(-) commit 0e59e091e7b3e65864c1ea83b85cec1f2a43c848 Author: William Casarin Date: Wed Jan 24 11:44:57 2018 -0800 test: switch invoice tests to use proper bip173 name Signed-off-by: William Casarin tests/test_lightningd.py | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) commit b30fb952e62c4a2d9077dee7af00e6e6b8474685 Author: William Casarin Date: Wed Jan 24 10:55:23 2018 -0800 chainparams: fix regtest bip173_name regtest bech32 hrp is bcrt, not tb Signed-off-by: William Casarin bitcoin/chainparams.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 37ea24e9c96fbab4984c886d6bd099103f5224dd Author: William Casarin Date: Tue Jan 23 23:01:21 2018 -0800 newaddr: support bech32 p2wpkh funding addresses * Add optional addresstype param to newaddr, which can be one of: - bech32 - p2sh-segwit - nothing (defaults to p2sh-segwit) The naming here mirrors bitcoind * txfilter already looks for p2wpkh outputs, so we're covered there Signed-off-by: William Casarin wallet/walletrpc.c | 49 +++++++++++++++++++++++++++++++++++++++++-------- 1 file changed, 41 insertions(+), 8 deletions(-) commit 5b4a62d822480c856d67edfd383d42f488eb7c95 Author: William Casarin Date: Thu Jan 25 10:01:08 2018 -0800 doc: some sqlite db info for HACKING Signed-off-by: William Casarin doc/HACKING.md | 26 ++++++++++++++++++++++++++ 1 file changed, 26 insertions(+) commit 8aee38162cf6d3ba6f8c389eedde56664750b33d Author: William Casarin Date: Mon Jan 22 14:45:00 2018 -0800 doc: Nix{,OS} build instructions Signed-off-by: William Casarin doc/INSTALL.md | 13 +++++++++++++ 1 file changed, 13 insertions(+) commit 3cb03ab784e1b546062de0fbd6c128e12775eb82 Author: William Casarin Date: Tue Jan 23 21:24:38 2018 -0800 bitcoin: add test programs to ALL_TEST_PROGRAMS * Add BITCOIN_TEST_PROGRAMS to ALL_TEST_PROGRAMS * Refactor bitcoin test make directives into its own Makefile under bitcoin/test Signed-off-by: William Casarin bitcoin/Makefile | 17 ++--------------- bitcoin/test/Makefile | 15 +++++++++++++++ 2 files changed, 17 insertions(+), 15 deletions(-) commit f8e5de1974c9843e798459b87214fdcba11b3b4e Author: William Casarin Date: Sun Jan 21 11:20:16 2018 -0800 listpeers: print channel configs Signed-off-by: William Casarin lightningd/peer_control.c | 9 +++++++++ 1 file changed, 9 insertions(+) commit 3e3dbfdd1b4aa1c5de89b5199f66108c5fc7ab3a Author: William Casarin Date: Sat Jan 13 22:00:26 2018 -0800 hacking: document subdaemon debugging Signed-off-by: William Casarin doc/HACKING.md | 12 ++++++++++++ 1 file changed, 12 insertions(+) commit 4a12cafe7fb48a73c311c696c58d0c1c7a1643e6 Author: William Casarin Date: Sat Jan 13 21:56:32 2018 -0800 debugging: add -ex return and cont to gdb command Have gdb execute return and continue when attaching to a subdaemon Signed-off-by: William Casarin common/subdaemon.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 44f9863192fc61d093b467fbf7d8306e8ee8d102 Author: William Casarin Date: Sun Jan 14 15:57:19 2018 -0800 permute_tx: bail on empty permute_{inputs/outputs} arguments permute_outputs is sometimes called with empty arguments from initial_commit_tx. Make sure we guard against that case. We also do the same in permute_inputs for good measure. Signed-off-by: William Casarin common/permute_tx.c | 8 ++++++++ 1 file changed, 8 insertions(+) commit 3c0d2813a09f85f6895b79663465c9bf18ca94e5 Author: William Casarin Date: Sat Jan 13 13:56:38 2018 -0800 bitcoind: properly handle spent outputs in gettxout exit status is not enough to detect spent outputs. gettxout will return a success exit code and 0 bytes. Signed-off-by: William Casarin lightningd/bitcoind.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) commit 2e796ffa67ffc131b19fe6a337fe96f3900b91b3 Author: William Casarin Date: Wed Jan 10 22:19:53 2018 -0800 peer_control: send addrhints in activate_peer Since we now have addresses in the database, we can resend them as hints to gossipd on startup. Signed-off-by: William Casarin lightningd/peer_control.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) commit 5043e201b8d198615272dec0b7bc967799b70ac2 Author: William Casarin Date: Tue Jan 9 09:04:11 2018 -0800 emacs: add .dir-locals.el for linux style C This will automatically configure proper indent settings for new contributors using emacs. Signed-off-by: William Casarin .dir-locals.el | 7 +++++++ 1 file changed, 7 insertions(+) commit 96f075c07ea0c9997a0186321e06e2c3b441516d Author: William Casarin Date: Wed Jan 3 16:59:14 2018 -0800 readme: note about walletbroadcast To save others the pain that I went through :[ Signed-off-by: William Casarin README.md | 3 +++ 1 file changed, 3 insertions(+) commit a1d215a46d6eaff23a2cc8b3c9ebdccd0dde65cb Author: William Casarin Date: Wed Jan 3 11:20:57 2018 -0800 make: append contrib/pylightning to PYTHONPATH Append contrib/pylightning instead of overriding PYTHONPATH for tests. Signed-off-by: William Casarin Makefile | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) commit bcd49b063b28a6d7595fb699cac9caffe7a0f459 Author: William Casarin Date: Wed Dec 20 10:50:08 2017 -0800 fixup! wallet: insert address into peers table wallet/wallet.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) commit ce1d709d44f4bad4d610c6bb43f35e1ee541afaf Author: William Casarin Date: Mon Dec 18 02:25:16 2017 -0800 wireaddr: fix ipv6 formatting with ports in fmt_wireaddr Correctly format ipv6 address with ports. This will also make it more compatible with the new parse_wireaddr, which has been updated to parse ports. They are inverses now. Also add some tests that check this. Signed-off-by: William Casarin common/test/run-ip_port_parsing.c | 32 ++++++++++++++++++++++++++++++++ common/wireaddr.c | 4 ++-- common/wireaddr.h | 2 ++ 3 files changed, 36 insertions(+), 2 deletions(-) commit d89eb32c85315e20a1ab1c57d5622c058317da41 Author: William Casarin Date: Mon Dec 18 02:17:15 2017 -0800 wallet: insert address into peers table It looks like we were missing the address on insert into the peers table. This will insert the address formatted by fmt_wireaddr. This happens to include the ip and port. This is fine, since parse_wireaddr has been updated to parse ports in ip address strings. Signed-off-by: William Casarin wallet/wallet.c | 19 +++++++++++++++++-- 1 file changed, 17 insertions(+), 2 deletions(-) commit 3e7aabe25679ce5e5d95f2cbd259f75f98b87c4e Author: William Casarin Date: Mon Dec 18 02:15:05 2017 -0800 test: add tests for parse_ip_port This tests the basic functionality of parse_ip_port, which is used in parse_wireaddr. Signed-off-by: William Casarin .gitignore | 1 + common/test/run-ip_port_parsing.c | 52 +++++++++++++++++++++++++++++++++++++++ 2 files changed, 53 insertions(+) commit 7ecccd50b94fe5a7d4b90101bab99bc6ec4fafea Author: William Casarin Date: Mon Dec 18 02:10:43 2017 -0800 wireaddr: add ip[:port] parsing * Add port parsing support to parse_wireaddr. This is in preparation for storing addresses in the peers table. This also makes parse_wireaddr a proper inverse of fmt_wireaddr. * Move parse_wireaddr to common/wireaddr.c this seems like a better place for it. I bring along parse_ip_port with it for convenience. This also fixes some issues with the upcoming ip/port parsing tests. Signed-off-by: William Casarin common/wireaddr.c | 83 +++++++++++++++++++++++++++++++++++++++++++++++++ common/wireaddr.h | 5 +++ lightningd/netaddress.c | 28 ----------------- lightningd/netaddress.h | 1 - wallet/test/Makefile | 3 ++ 5 files changed, 91 insertions(+), 29 deletions(-) commit 52f741de97399e3c1e4fdb033840ed9b35ca1de3 Author: William Casarin Date: Mon Oct 9 03:52:09 2017 -0700 tools/generate-wire.py: generalize python3 path Generalize generate-wire.py python3 path Signed-off-by: Rusty Russell tools/generate-wire.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)